[
https://issues.apache.org/jira/browse/HBASE-10092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16297162#comment-16297162
]
stack commented on HBASE-10092:
-------------------------------
bq. The description of this issue suggests that.
Yeah. Its wrong (smile). We're going to slf4j under the rubric of this issue.
Can update the summary.
bq. I think it needs to be configured.
SLF4J doc says it will only show if backend is logback. Otherwise, dropped.
Good to have it though. We'll have to call out in release notes that FATAL no
longer shows in our logs (usually)
bq. Appy mentioned it, guards are useful if it is expensive to build the log
message. Parameterized loggers are also useful, because they only build the log
message if it is going to be logged.
We want to remove guards and use parameterized log message construction from
here on out. I like [~appy] suggestion that we do this piecemeal, as we go. The
guards are fine for now but should be replaced.
Thanks B.
> Move up on to log4j2
> --------------------
>
> Key: HBASE-10092
> URL: https://issues.apache.org/jira/browse/HBASE-10092
> Project: HBase
> Issue Type: Sub-task
> Reporter: stack
> Assignee: Balazs Meszaros
> Priority: Critical
> Fix For: 2.0.0-beta-1
>
> Attachments: 10092.txt, 10092v2.txt, HBASE-10092-preview-v0.patch,
> HBASE-10092.master.001.patch, HBASE-10092.master.002.patch,
> HBASE-10092.master.003.patch, HBASE-10092.patch
>
>
> Allows logging with less friction. See http://logging.apache.org/log4j/2.x/
> This rather radical transition can be done w/ minor change given they have an
> adapter for apache's logging, the one we use. They also have and adapter for
> slf4j so we likely can remove at least some of the 4 versions of this module
> our dependencies make use of.
> I made a start in attached patch but am currently stuck in maven dependency
> resolve hell courtesy of our slf4j. Fixing will take some concentration and
> a good net connection, an item I currently lack. Other TODOs are that will
> need to fix our little log level setting jsp page -- will likely have to undo
> our use of hadoop's tool here -- and the config system changes a little.
> I will return to this project soon. Will bring numbers.
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
