[
https://issues.apache.org/jira/browse/HBASE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199376#comment-13199376
]
Zhihong Yu commented on HBASE-5325:
-----------------------------------
If you can upload patch to https://reviews.apache.org, that would help reviewer
provide better review comments.
{code}
+ if (mxBean != null) {
+ MBeans.unregister(mxBean);
+ }
{code}
Please assign null to mxBean after unregistration.
{code}
+ mxBean = MBeans.register("HBase", "HBaseMasterInfo", this);
{code}
For the second parameter, "MasterInfo" should be good enough.
There is no need to include year in HBaseMasterMXBean.java header.
There are extra whitespaces in this file.
> Expose basic information about the master-status through jmx beans
> -------------------------------------------------------------------
>
> Key: HBASE-5325
> URL: https://issues.apache.org/jira/browse/HBASE-5325
> Project: HBase
> Issue Type: Bug
> Reporter: Hitesh Shah
> Priority: Minor
> Attachments: HBASE-5325.wip.patch
>
>
> Similar to the Namenode and Jobtracker, it would be good if the hbase master
> could expose some information through mbeans.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
