[
https://issues.apache.org/jira/browse/HBASE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199542#comment-13199542
]
stack commented on HBASE-5325:
------------------------------
Can the bean implementation be outside of the master? Just wondering if we can
save having HMaster implement yet another Interface (as I'm sure you've
noticed, this is a bloated class much in need a refactor; adding more stuff to
this class makes the DOR -- Day Of Refactor -- an even longer day.
{code}
+ mxBean = MBeans.register("HBase", "HBaseMasterInfo", this);
{code}
Is this a good name for our bean? Should it be at org.apache.hbase -- I don't
remember how you do that -- and the bean name be just Master (I can imagine one
day the ServerManager and the AssignmentManager registering mbeans...)
On JSON'ing it, is that the way to go? Can we not make MBeans instead -- and
MBean per regionserver or a an MBean pointer to list of all registered MBeans
(This would be a federated MBean? Pardon me if this is all nonsense, its a
while since I've done this stuff). So, if CoProcessors implemented MBean, you
could output list of MBeans as result of query on Master getCoProcessors.
getDeadRegionServers should return a List of Strings... or whatever the MBean
digestible format of an MBean list of Strings is.
Similar getRegionsInTransition.
Else patch looks great.
What you think about the MBean being actionable; i.e. setters so we could
change certain values (not regionservers or coprocessors, but maybe future
stuff....)
Patch looks great. Thanks for digging in here.
> Expose basic information about the master-status through jmx beans
> -------------------------------------------------------------------
>
> Key: HBASE-5325
> URL: https://issues.apache.org/jira/browse/HBASE-5325
> Project: HBase
> Issue Type: Bug
> Reporter: Hitesh Shah
> Priority: Minor
> Attachments: HBASE-5325.wip.patch
>
>
> Similar to the Namenode and Jobtracker, it would be good if the hbase master
> could expose some information through mbeans.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
