[
https://issues.apache.org/jira/browse/HBASE-20074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376005#comment-16376005
]
Eshcar Hillel commented on HBASE-20074:
---------------------------------------
There are two options for handling this:
(1) leave one statement so both CAM and CCM are assigned the same default value
(0.1)
(2) leave two statements and have one default for CCM (0.1) and one for CAM
(0.02)
it's a tradeoff between simplicity and optimal value in some settings. 0.1 also
had good results for CAM (the advantage of 0.02 was not big) so either choices
are ok.
> [FindBugs] Same code on both branches in
> CompactingMemStore#initMemStoreCompactor
> ---------------------------------------------------------------------------------
>
> Key: HBASE-20074
> URL: https://issues.apache.org/jira/browse/HBASE-20074
> Project: HBase
> Issue Type: Bug
> Components: findbugs
> Reporter: stack
> Assignee: Gali Sheffi
> Priority: Major
>
> [~galish] Our findbugs checking was disabled for a few weeks and we just
> turned it on again. It found a good one. Mind fixing it please? Meantime I've
> undone the if class to get a factor dependent on index type. Thanks.
> Code Warning
> DB
> org.apache.hadoop.hbase.regionserver.CompactingMemStore.initInmemoryFlushSize(Configuration)
> uses the same code for two branches
> Bug type DB_DUPLICATE_BRANCHES (click for details)
> In class org.apache.hadoop.hbase.regionserver.CompactingMemStore
> In method
> org.apache.hadoop.hbase.regionserver.CompactingMemStore.initInmemoryFlushSize(Configuration)
> At CompactingMemStore.java:[line 140]
> At CompactingMemStore.java:[line 143]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
