[
https://issues.apache.org/jira/browse/HBASE-20074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376463#comment-16376463
]
Chia-Ping Tsai commented on HBASE-20074:
----------------------------------------
Is there any perf test for option 2? If option 2 is adopted, should we
introduce different config key to config the factor for CCM and CAM? Or we can
use option 1 to fix the findbugs warning, and then file another Jira to
continue the discussion for different configs.
> [FindBugs] Same code on both branches in
> CompactingMemStore#initMemStoreCompactor
> ---------------------------------------------------------------------------------
>
> Key: HBASE-20074
> URL: https://issues.apache.org/jira/browse/HBASE-20074
> Project: HBase
> Issue Type: Bug
> Components: findbugs
> Reporter: stack
> Assignee: Gali Sheffi
> Priority: Major
>
> [~galish] Our findbugs checking was disabled for a few weeks and we just
> turned it on again. It found a good one. Mind fixing it please? Meantime I've
> undone the if class to get a factor dependent on index type. Thanks.
> Code Warning
> DB
> org.apache.hadoop.hbase.regionserver.CompactingMemStore.initInmemoryFlushSize(Configuration)
> uses the same code for two branches
> Bug type DB_DUPLICATE_BRANCHES (click for details)
> In class org.apache.hadoop.hbase.regionserver.CompactingMemStore
> In method
> org.apache.hadoop.hbase.regionserver.CompactingMemStore.initInmemoryFlushSize(Configuration)
> At CompactingMemStore.java:[line 140]
> At CompactingMemStore.java:[line 143]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
