[
https://issues.apache.org/jira/browse/HBASE-20074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376594#comment-16376594
]
Eshcar Hillel commented on HBASE-20074:
---------------------------------------
Gali already tried it and didn't see any change in the results.
However we also noticed some unexpected behavior with different settings of
WAL. It is definitely still a "suspect".
> [FindBugs] Same code on both branches in
> CompactingMemStore#initMemStoreCompactor
> ---------------------------------------------------------------------------------
>
> Key: HBASE-20074
> URL: https://issues.apache.org/jira/browse/HBASE-20074
> Project: HBase
> Issue Type: Bug
> Components: findbugs
> Reporter: stack
> Assignee: Gali Sheffi
> Priority: Major
> Attachments: HBASE-20074-V01.patch
>
>
> [~galish] Our findbugs checking was disabled for a few weeks and we just
> turned it on again. It found a good one. Mind fixing it please? Meantime I've
> undone the if class to get a factor dependent on index type. Thanks.
> Code Warning
> DB
> org.apache.hadoop.hbase.regionserver.CompactingMemStore.initInmemoryFlushSize(Configuration)
> uses the same code for two branches
> Bug type DB_DUPLICATE_BRANCHES (click for details)
> In class org.apache.hadoop.hbase.regionserver.CompactingMemStore
> In method
> org.apache.hadoop.hbase.regionserver.CompactingMemStore.initInmemoryFlushSize(Configuration)
> At CompactingMemStore.java:[line 140]
> At CompactingMemStore.java:[line 143]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
