stack commented on HBASE-20105:

Good on you [~jmspaggi] 

Add this config. to the release note. Release note should say how to enable 
this facility and what to monitor for to verify it working properly. Here's the 
config to add to RN: public static final String FLUSH_STORAGE_POLICY = 
"hbase.hstore.flush.storagepolicy"; Add an example too...

For the future, write log strings like this now.. instead of:

LOG.trace("Setting storagePolicy " + storagePolicy + " for flushed file.");


LOG.trace("Setting storagePolicy {} for flushed file.", storagePolicy);

... its slf4j MessageFormatter... see 

Need brackets after the 'if' here:

342               if (fs instanceof HFileSystem)
343                 fileSystem = ((HFileSystem)fs).getBackingFs();

Its ok if this comes back null


... hmmm... it looks like it going by a few lines later.

... or what if it returns gobble-de-gook? Should we check it makes sense?

Should there be an assign here?

467           String policyName = storagePolicy;
468           if (null == policyName) {
469             this.conf.get(ColumnFamilyDescriptorBuilder.STORAGE_POLICY);

.. i.e. when you do this.conf.get.. should you assign to policyName?

Looks good [~jmspaggi] You have any results w/ this in place on SSDs?

> Allow flushes to target SSD storage
> -----------------------------------
>                 Key: HBASE-20105
>                 URL: https://issues.apache.org/jira/browse/HBASE-20105
>             Project: HBase
>          Issue Type: New Feature
>          Components: Performance, regionserver
>    Affects Versions: hbase-2.0.0-alpha-4
>            Reporter: Jean-Marc Spaggiari
>            Assignee: Jean-Marc Spaggiari
>            Priority: Major
>             Fix For: 2.0.0
>         Attachments: HBASE-20105-v0.patch, HBASE-20105-v1.patch, 
> HBASE-20105-v2.patch, HBASE-20105-v3.patch, HBASE-20105-v4.patch, 
> HBASE-20105-v5.patch
> On heavy writes usecases, flushes are compactes together pretty quickly. 
> Allowing flushes to go on SSD allows faster flush and faster first 
> compactions. Subsequent compactions going on regular storage.
> I will be interesting to have an option to target SSD for flushes.

This message was sent by Atlassian JIRA

Reply via email to