[ 
https://issues.apache.org/jira/browse/HBASE-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207272#comment-13207272
 ] 

Gregory Chanan commented on HBASE-5317:
---------------------------------------

@Ted:

I tried approach #1, but it seems like it is not kosher to have the test depend 
on the maven packaging step.  For example:
{code}
mvn -Dhadoop.profile=23 -DskipTests package
mvn -Dhadoop.profile=23 test ...
{code}

works, but
{code}
mvn -Dhadoop.profile=23 clean test ...
{code}
fails because the jars aren't even built without the package step.

#2 will probably work in both cases.  It don't think it's great either, because 
ideally the tests should exercise the jars, because that is what downstream 
users would be running against.  I think testing against the jars requires 
making hbase a multi-module project and is therefore probably:
0) outside the scope of this JIRA
1) a lot of work
2) should be discussed in the community

Therefore, I propose getting attempt #2 to work and filing a JIRA to figure out 
a better packaging story so we can later get rid of #2.
                
> Fix TestHFileOutputFormat to work against hadoop 0.23
> -----------------------------------------------------
>
>                 Key: HBASE-5317
>                 URL: https://issues.apache.org/jira/browse/HBASE-5317
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.94.0, 0.92.0
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>         Attachments: HBASE-5317-v0.patch, HBASE-5317-v1.patch
>
>
> Running
> mvn -Dhadoop.profile=23 test -P localTests 
> -Dtest=org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
> yields this on 0.92:
> Failed tests:   
> testColumnFamilyCompression(org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat):
>  HFile for column family info-A not found
> Tests in error: 
>   test_TIMERANGE(org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat): 
> /home/gchanan/workspace/apache92/target/test-data/276cbd0c-c771-4f81-9ba8-c464c9dd7486/test_TIMERANGE_present/_temporary/0/_temporary/_attempt_200707121733_0001_m_000000_0
>  (Is a directory)
>   
> testMRIncrementalLoad(org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat):
>  TestTable
>   
> testMRIncrementalLoadWithSplit(org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat):
>  TestTable
> It looks like on trunk, this also results in an error:
>   
> testExcludeMinorCompaction(org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat):
>  TestTable
> I have a patch that fixes testColumnFamilyCompression and test_TIMERANGE, but 
> haven't fixed the other 3 yet.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to