[
https://issues.apache.org/jira/browse/HBASE-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210678#comment-13210678
]
[email protected] commented on HBASE-5317:
------------------------------------------------------
bq. On 2012-02-17 00:49:13, Michael Stack wrote:
bq. > Minor nits. +1 otherwise.
Thanks for the reviews, Ted and Stack.
bq. On 2012-02-17 00:49:13, Michael Stack wrote:
bq. > pom.xml, line 2001
bq. > <https://reviews.apache.org/r/3939/diff/1/?file=75517#file75517line2001>
bq. >
bq. > Whats DS? (Sorry if I'm being extra thick here)
Distributed Shell (hadoop-yarn-applications-distributedshell)
bq. On 2012-02-17 00:49:13, Michael Stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java,
line 515
bq. > <https://reviews.apache.org/r/3939/diff/1/?file=75519#file75519line515>
bq. >
bq. > Is this because we're running against target/classes dir?
Right. HBase is a single module project and the maven test phase is before the
maven package phase (when the jars are built).
This is discussed briefly on the JIRA, but I think the correct long-term
solution is to make HBase a multi-module project (see HBASE-4336) and make a
test module that depends on the core module.
- Gregory
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3939/#review5180
-----------------------------------------------------------
On 2012-02-16 21:57:38, Gregory Chanan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3939/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-16 21:57:38)
bq.
bq.
bq. Review request for hbase, Ted Yu and Michael Stack.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. NOTE: To get TestHFileOutputFormat passing also requires HBASE-5346, which
has been reviewed but not committed yet.
bq.
bq. Fixes a few issues interacting with the new mapreduce in 0.23:
bq. - Maven dependency issue
bq. - Change the hbaseRootDir so that mrv2 output is not confused with an
hbase table
bq. - Create Jars necessary to run mrv2 jobs at unit test time (before hbase
jars have been built)
bq.
bq.
bq. This addresses bug HBASE-5317.
bq. https://issues.apache.org/jira/browse/HBASE-5317
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. pom.xml f24b389
bq. src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat.java
c5222c2
bq. src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java
ff38731
bq. src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java ec9d581
bq.
bq. Diff: https://reviews.apache.org/r/3939/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Gregory
bq.
bq.
> Fix TestHFileOutputFormat to work against hadoop 0.23
> -----------------------------------------------------
>
> Key: HBASE-5317
> URL: https://issues.apache.org/jira/browse/HBASE-5317
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0, 0.92.0
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Attachments: HBASE-5317-v0.patch, HBASE-5317-v1.patch
>
>
> Running
> mvn -Dhadoop.profile=23 test -P localTests
> -Dtest=org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
> yields this on 0.92:
> Failed tests:
> testColumnFamilyCompression(org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat):
> HFile for column family info-A not found
> Tests in error:
> test_TIMERANGE(org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat):
> /home/gchanan/workspace/apache92/target/test-data/276cbd0c-c771-4f81-9ba8-c464c9dd7486/test_TIMERANGE_present/_temporary/0/_temporary/_attempt_200707121733_0001_m_000000_0
> (Is a directory)
>
> testMRIncrementalLoad(org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat):
> TestTable
>
> testMRIncrementalLoadWithSplit(org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat):
> TestTable
> It looks like on trunk, this also results in an error:
>
> testExcludeMinorCompaction(org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat):
> TestTable
> I have a patch that fixes testColumnFamilyCompression and test_TIMERANGE, but
> haven't fixed the other 3 yet.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
