[ 
https://issues.apache.org/jira/browse/HBASE-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209784#comment-13209784
 ] 

[email protected] commented on HBASE-5317:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3939/
-----------------------------------------------------------

Review request for hbase, Ted Yu and Michael Stack.


Summary
-------

NOTE: To get TestHFileOutputFormat passing also requires HBASE-5346, which has 
been reviewed but not committed yet.

Fixes a few issues interacting with the new mapreduce in 0.23:
- Maven dependency issue
- Change the hbaseRootDir so that mrv2 output is not confused with an hbase 
table
- Create Jars necessary to run mrv2 jobs at unit test time (before hbase jars 
have been built) 


This addresses bug HBASE-5317.
    https://issues.apache.org/jira/browse/HBASE-5317


Diffs
-----

  pom.xml f24b389 
  src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat.java 
c5222c2 
  src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java 
ff38731 
  src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java ec9d581 

Diff: https://reviews.apache.org/r/3939/diff


Testing
-------


Thanks,

Gregory


                
> Fix TestHFileOutputFormat to work against hadoop 0.23
> -----------------------------------------------------
>
>                 Key: HBASE-5317
>                 URL: https://issues.apache.org/jira/browse/HBASE-5317
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.94.0, 0.92.0
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>         Attachments: HBASE-5317-v0.patch, HBASE-5317-v1.patch
>
>
> Running
> mvn -Dhadoop.profile=23 test -P localTests 
> -Dtest=org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
> yields this on 0.92:
> Failed tests:   
> testColumnFamilyCompression(org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat):
>  HFile for column family info-A not found
> Tests in error: 
>   test_TIMERANGE(org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat): 
> /home/gchanan/workspace/apache92/target/test-data/276cbd0c-c771-4f81-9ba8-c464c9dd7486/test_TIMERANGE_present/_temporary/0/_temporary/_attempt_200707121733_0001_m_000000_0
>  (Is a directory)
>   
> testMRIncrementalLoad(org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat):
>  TestTable
>   
> testMRIncrementalLoadWithSplit(org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat):
>  TestTable
> It looks like on trunk, this also results in an error:
>   
> testExcludeMinorCompaction(org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat):
>  TestTable
> I have a patch that fixes testColumnFamilyCompression and test_TIMERANGE, but 
> haven't fixed the other 3 yet.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to