[
https://issues.apache.org/jira/browse/HBASE-19258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408870#comment-16408870
]
Mike Drob commented on HBASE-19258:
-----------------------------------
{code}
+ if (plugins != null) {
+ conf.set(HFileCleaner.MASTER_HFILE_CLEANER_PLUGINS, (plugins == null ?
"" : plugins + ",") +
+ BackupHFileCleaner.class.getName());
+ }
{code}
redundant null checks
{code}
LOG.debug("Added log cleaner: " + cleanerClass + "\n" + "Added master
procedure manager: "
- + masterProcedureClass);
+ + masterProcedureClass+"\n"+ "Added HFile cleaner: "+
BackupHFileCleaner.class.getName());
+
{code}
nit: parameterized logging
{code}
+import com.google.common.util.concurrent.Uninterruptibles;
{code}
should be thirdparty?
I see a few things that look like they will be checkstyle issues, I won't list
them because I assume QA will find them.
{code}
+ LOG.info(String.format("Creating table %s with %d splits.", tableName,
regionsCountPerServer));
- LOG.info(String.format("Pre-split table created successfully in %dms.",
- (endTime - startTime)));
+ LOG.info(String.format("Pre-split table created successfully in %dms.",
(endTime - startTime)));
{code}
parameterized logging again, please. There's more places later, I'm not going
to list each individually
{code}
+ LOG.info("create full backup image for ");
{code}
Missing table name?
{code}
+ rowsInIteration =
+ Integer.parseInt(cmd.getOptionValue(ROWS_PER_ITERATION_KEY,
+ Integer.toString(DEFAULT_ROWS_IN_ITERATION)));
{code}
This is super gross but I don't know if there's a better way
> IntegrationTest for Backup and Restore
> --------------------------------------
>
> Key: HBASE-19258
> URL: https://issues.apache.org/jira/browse/HBASE-19258
> Project: HBase
> Issue Type: Test
> Components: integration tests
> Reporter: Josh Elser
> Assignee: Vladimir Rodionov
> Priority: Blocker
> Fix For: 3.0.0
>
> Attachments: HBASE-19258.v1.patch
>
>
> See chatter at https://docs.google.com/document/d/1xbPlLKjOcPq2LDqjbSkF6uND
> AG0mzgOxek6P3POLeMc/edit?usp=sharing
> We need to get an IntegrationTest in place for backup and restore.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
