[
https://issues.apache.org/jira/browse/HBASE-19258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16410723#comment-16410723
]
Ted Yu commented on HBASE-19258:
--------------------------------
I suggest using
https://google.github.io/guava/releases/19.0/api/docs/com/google/common/util/concurrent/Uninterruptibles.html#joinUninterruptibly(java.lang.Thread,
long, java.util.concurrent.TimeUnit) so that the test wouldn't hang in case
any of the threads gets stuck.
{code}
+ LOG.info("Creating table {} with {} splits.", tableName,
regionsCountPerServer);
{code}
The variable says per server, but the log seems to indicate something else
w.r.t. regionsCountPerServer.
{code}
+ ColumnFamilyDescriptor[] columns = new ColumnFamilyDescriptor[] {
cbuilder.build() };
{code}
nit: put curly braces on different lines.
{code}
+ // Restore incremental backup for table, with overwrite for previous
backup
...
+ // Restore incremental backup for table, with overwrite for last backup
{code}
It seems the above two snippets are very similar and can be implemented in one
(common) method.
> IntegrationTest for Backup and Restore
> --------------------------------------
>
> Key: HBASE-19258
> URL: https://issues.apache.org/jira/browse/HBASE-19258
> Project: HBase
> Issue Type: Test
> Components: integration tests
> Reporter: Josh Elser
> Assignee: Vladimir Rodionov
> Priority: Blocker
> Fix For: 3.0.0
>
> Attachments: HBASE-19258.v1.patch, HBASE-19258.v2.patch
>
>
> See chatter at https://docs.google.com/document/d/1xbPlLKjOcPq2LDqjbSkF6uND
> AG0mzgOxek6P3POLeMc/edit?usp=sharing
> We need to get an IntegrationTest in place for backup and restore.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
