[
https://issues.apache.org/jira/browse/HBASE-5241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209142#comment-13209142
]
Phabricator commented on HBASE-5241:
------------------------------------
tedyu has commented on the revision "HBASE-5241 [jira] Deletes should not mask
Puts that come after it.".
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/HConstants.java:402 Put HBASE-5241 here.
src/main/java/org/apache/hadoop/hbase/HConstants.java:408 Should this be
turned off by default ?
src/main/java/org/apache/hadoop/hbase/regionserver/DeleteTracker.java:45 Add
@param for memstoreTS in these two methods.
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:1750 If there
is no better way of handling, remove this line.
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:1763 This
special constant should be defined and documented.
src/main/java/org/apache/hadoop/hbase/regionserver/ScanDeleteTracker.java:49
This member doesn't seem to be used anywhere.
src/main/java/org/apache/hadoop/hbase/regionserver/ScanDeleteTracker.java:50
This neither.
src/main/java/org/apache/hadoop/hbase/regionserver/ScanDeleteTracker.java:66
Would memstoreTSForDelete be a better name ?
Add comment please.
src/main/java/org/apache/hadoop/hbase/regionserver/ScanDeleteTracker.java:65
Would timestampForDelete be better name ?
src/main/java/org/apache/hadoop/hbase/regionserver/ScanDeleteTracker.java:89
Add @param for memstoreTS.
src/main/java/org/apache/hadoop/hbase/regionserver/ScanDeleteTracker.java:93
Indentation for these two lines.
src/main/java/org/apache/hadoop/hbase/regionserver/ScanDeleteTracker.java:60
Add comments for these fields please
src/main/java/org/apache/hadoop/hbase/regionserver/ScanDeleteTracker.java:62
How about naming this field memstoreTSForDeleteCol ?
src/main/java/org/apache/hadoop/hbase/regionserver/ScanDeleteTracker.java:118
Should we consider checking these two timestamps separately ?
REVISION DETAIL
https://reviews.facebook.net/D1731
> Deletes should not mask Puts that come after it.
> ------------------------------------------------
>
> Key: HBASE-5241
> URL: https://issues.apache.org/jira/browse/HBASE-5241
> Project: HBase
> Issue Type: Improvement
> Reporter: Amitanand Aiyer
> Attachments: HBASE-5241.D1731.1.patch, HBASE-5241.D1731.2.patch
>
>
> Suppose that we have a delete row, and then followed by the put. The delete
> row
> can mask the put, unless there was a major compaction in between.
> Now that we are flushing the memstoreTS to disk, along with the KVs, we
> should be able
> to differentiate whether or not the Put happened after the Delete and offer
> better
> delete semantics.
> Couldn't find a pre-existing JIRA that already discusses this, so creating
> one.
> Seems related to https://issues.apache.org/jira/browse/HBASE-2406, but is not
> quite the same.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
