[
https://issues.apache.org/jira/browse/HBASE-5241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210097#comment-13210097
]
Phabricator commented on HBASE-5241:
------------------------------------
lhofhansl has commented on the revision "HBASE-5241 [jira] Deletes should not
mask Puts that come after it.".
I have voiced my concern amply in the jira :)
Implementation-wise this is looks reasonable enough. See a few questions and
comments inline.
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:1748 Is this
right? Now we're always dating column or family way into the future.
src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java:223
See HBASE-4926 on why this might be a performance problem.
The seeking was just recently put in to address issues like this.
src/main/java/org/apache/hadoop/hbase/regionserver/ScanDeleteTracker.java:155
Ugh... Although there shouldn't be too many family delete markers.
Are you going to do some performance tests (or is this in production at FB
already?)
src/main/java/org/apache/hadoop/hbase/regionserver/ScanDeleteTracker.java:155
This needs to conditioned on ENFORCE_STRICTER_SEMANTICS, right?
src/main/java/org/apache/hadoop/hbase/regionserver/ScanDeleteTracker.java:166
Same here
src/main/java/org/apache/hadoop/hbase/regionserver/ScanDeleteTracker.java:173
and here
REVISION DETAIL
https://reviews.facebook.net/D1731
> Deletes should not mask Puts that come after it.
> ------------------------------------------------
>
> Key: HBASE-5241
> URL: https://issues.apache.org/jira/browse/HBASE-5241
> Project: HBase
> Issue Type: Improvement
> Reporter: Amitanand Aiyer
> Assignee: Amitanand Aiyer
> Attachments: HBASE-5241.D1731.1.patch, HBASE-5241.D1731.2.patch,
> HBASE-5241.D1731.3.patch
>
>
> Suppose that we have a delete row, and then followed by the put. The delete
> row
> can mask the put, unless there was a major compaction in between.
> Now that we are flushing the memstoreTS to disk, along with the KVs, we
> should be able
> to differentiate whether or not the Put happened after the Delete and offer
> better
> delete semantics.
> Couldn't find a pre-existing JIRA that already discusses this, so creating
> one.
> Seems related to https://issues.apache.org/jira/browse/HBASE-2406, but is not
> quite the same.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
