[ 
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16454643#comment-16454643
 ] 

Sean Busbey commented on HBASE-20478:
-------------------------------------

I pushed this to master, but in backporting ran into a problem where I can't 
make it fail. I think that's also true on master, so I might revert.

here's a patch for QAbot that inserts each of the things we were checking for 
before htis patch.

> move import checks from hbaseanti to checkstyle
> -----------------------------------------------
>
>                 Key: HBASE-20478
>                 URL: https://issues.apache.org/jira/browse/HBASE-20478
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>            Reporter: Sean Busbey
>            Assignee: Mike Drob
>            Priority: Minor
>         Attachments: HBASE-20478.0.patch, HBASE-20478.1.patch, 
> HBASE-20478.2.patch, HBASE-20478.3.patch, HBASE-20478.WIP.2.patch, 
> HBASE-20478.WIP.2.patch, HBASE-20478.WIP.patch, HBASE-anti-check.patch
>
>
> came up in discussion on HBASE-20332. our check of "don't do this" things in 
> the codebase doesn't log the specifics of complaints anywhere, which forces 
> those who want to follow up to reverse engineer the check.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to