[ 
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16455636#comment-16455636
 ] 

Mike Drob commented on HBASE-20478:
-----------------------------------

Checkstyle 7+ requires JDK 8+, so won't be able to backport such a fix to 
branch-1, AFAICT.

v4:
- update checkstyle version
- update checkstyle plugin version
- move the import checks from anti to checkstyle

couldn't verify this locally because checkstyle doesn't run in the normal maven 
build anymore and for some reason test-patch was ignoring the checkstyle plugin 
for me (maybe related to HBASE-20467)

> move import checks from hbaseanti to checkstyle
> -----------------------------------------------
>
>                 Key: HBASE-20478
>                 URL: https://issues.apache.org/jira/browse/HBASE-20478
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>            Reporter: Sean Busbey
>            Assignee: Mike Drob
>            Priority: Minor
>         Attachments: HBASE-20478.0.patch, HBASE-20478.1.patch, 
> HBASE-20478.2.patch, HBASE-20478.3.patch, HBASE-20478.4.patch, 
> HBASE-20478.WIP.2.patch, HBASE-20478.WIP.2.patch, HBASE-20478.WIP.patch, 
> HBASE-anti-check.patch
>
>
> came up in discussion on HBASE-20332. our check of "don't do this" things in 
> the codebase doesn't log the specifics of complaints anywhere, which forces 
> those who want to follow up to reverse engineer the check.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to