[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16454671#comment-16454671
]
Mike Drob commented on HBASE-20478:
-----------------------------------
you're right, running locally I get:
{noformat}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-checkstyle-plugin:2.17:checkstyle (default-cli)
on project hbase-server: An error has occurred in Checkstyle report
generation.: Failed during checkstyle configuration: cannot initialize module
TreeWalker - Property 'illegalClasses' in module IllegalImport does not exist,
please check the documentation -> [Help 1]
{noformat}
The illegalClasses element was added in Checkstyle 7.8 -
http://checkstyle.sourceforge.net/config_imports.html#IllegalImport
By default the checkstyle plugin uses Checkstyle 6.18 -
https://maven.apache.org/plugins/maven-checkstyle-plugin/
I think we can try upgrading it to a newer version -
https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/upgrading-checkstyle.html
There's a lot of newer options out there -
http://central.maven.org/maven2/com/puppycrawl/tools/checkstyle/
> move import checks from hbaseanti to checkstyle
> -----------------------------------------------
>
> Key: HBASE-20478
> URL: https://issues.apache.org/jira/browse/HBASE-20478
> Project: HBase
> Issue Type: Improvement
> Components: test
> Reporter: Sean Busbey
> Assignee: Mike Drob
> Priority: Minor
> Attachments: HBASE-20478.0.patch, HBASE-20478.1.patch,
> HBASE-20478.2.patch, HBASE-20478.3.patch, HBASE-20478.WIP.2.patch,
> HBASE-20478.WIP.2.patch, HBASE-20478.WIP.patch, HBASE-anti-check.patch
>
>
> came up in discussion on HBASE-20332. our check of "don't do this" things in
> the codebase doesn't log the specifics of complaints anywhere, which forces
> those who want to follow up to reverse engineer the check.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
