[ 
https://issues.apache.org/jira/browse/HBASE-20334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16484645#comment-16484645
 ] 

Sean Busbey commented on HBASE-20334:
-------------------------------------

bq -1   shellcheck      0m 2s   The patch generated 1 new + 2 unchanged - 0 
fixed = 3 total (was 2)

interesting. this is reading in a heredoc, mistakenly. I'll see if I can ignore 
it.

bq. -1  whitespace      0m 0s   The patch has 29 line(s) that end in 
whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer 
https://git-scm.com/docs/git-apply
bq. -1  whitespace      0m 1s   The patch 48 line(s) with tabs.

This is the TSV file the test uses with the importtsv MR job. I'll see if I can 
ignore it.

> add a test that expressly uses both our shaded client and the one from hadoop 
> 3
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-20334
>                 URL: https://issues.apache.org/jira/browse/HBASE-20334
>             Project: HBase
>          Issue Type: Sub-task
>          Components: hadoop3, shading
>    Affects Versions: 2.0.0
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Major
>         Attachments: HBASE-20334.0.patch
>
>
> Since we're making a shaded client that bleed out of our namespace and into 
> Hadoop's, we should ensure that we can show our clients coexisting. Even if 
> it's just an IT that successfully talks to both us and HDFS via our 
> respective shaded clients, that'd be a big help in keeping us proactive.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to