[ 
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487597#comment-16487597
 ] 

Mike Drob commented on HBASE-20478:
-----------------------------------

Yea, I think this means we weren't running checkstyle in the nightlies at all 
before, because there's no way that 
https://builds.apache.org/job/HBase%20Nightly/job/HBASE-20478/3/artifact/output-general/branch-checkstyle-root.txt
 is supposed to be empty.

[~Jan Hentschel] - do you know which modules had been scrubbed for checkstyle 
and which still had work to do?

> move import checks from hbaseanti to checkstyle
> -----------------------------------------------
>
>                 Key: HBASE-20478
>                 URL: https://issues.apache.org/jira/browse/HBASE-20478
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>            Reporter: Sean Busbey
>            Assignee: Mike Drob
>            Priority: Minor
>         Attachments: HBASE-20478.0.patch, HBASE-20478.1.patch, 
> HBASE-20478.2.patch, HBASE-20478.3.patch, HBASE-20478.4.patch, 
> HBASE-20478.WIP.2.patch, HBASE-20478.WIP.2.patch, HBASE-20478.WIP.patch, 
> HBASE-anti-check.patch
>
>
> came up in discussion on HBASE-20332. our check of "don't do this" things in 
> the codebase doesn't log the specifics of complaints anywhere, which forces 
> those who want to follow up to reverse engineer the check.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to