[
https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16491778#comment-16491778
]
Mike Drob commented on HBASE-20478:
-----------------------------------
{noformat}
mdrob@mdrob-MBP:~/IdeaProjects/hbase$ diff ../checkstyle6 <(mvn
checkstyle:checkstyle -Dcheckstyle.consoleOutput=true | grep ERROR) | grep -v
Indentation | grep -v ImportOrder | grep -e '^>'
{noformat}
I managed to get both checkstyle versions to run locally, and compared the
results. Skipped the following:
* Indentation, because the warnings themselves didn't change, but the warning
message text did.
* ImportOrder, this is the big one complaining about whitespace separation. I
think we can just ignore it since we largely look at the delta in precommit?
I'll figure out how to fully suppress this in a follow on.
Fixed a ton of javadoc issues while going through this.
> move import checks from hbaseanti to checkstyle
> -----------------------------------------------
>
> Key: HBASE-20478
> URL: https://issues.apache.org/jira/browse/HBASE-20478
> Project: HBase
> Issue Type: Improvement
> Components: test
> Reporter: Sean Busbey
> Assignee: Mike Drob
> Priority: Minor
> Attachments: HBASE-20478.0.patch, HBASE-20478.1.patch,
> HBASE-20478.2.patch, HBASE-20478.3.patch, HBASE-20478.4.patch,
> HBASE-20478.WIP.2.patch, HBASE-20478.WIP.2.patch, HBASE-20478.WIP.patch,
> HBASE-anti-check.patch
>
>
> came up in discussion on HBASE-20332. our check of "don't do this" things in
> the codebase doesn't log the specifics of complaints anywhere, which forces
> those who want to follow up to reverse engineer the check.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
