[
https://issues.apache.org/jira/browse/HBASE-20862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16537850#comment-16537850
]
Duo Zhang commented on HBASE-20862:
-----------------------------------
I think the only problem here is the
HConstants.DEFAULT_ZOOKEPER_MAX_CLIENT_CNXNS? We should mark it as Deprecated
and added it back.
For ReplicationPeer it is marked as IA.LimitedPrivate so it is fine as we can
make break changes to it for a minor release. And for the interface itself, it
is used to get the information of a peer, it should not be implemented by CP
users?
And for ReplicationPeerConfigBuilder, IIRC we have added a note in our ref
guide, for IA.Public interfaces we are allowed to add methods without default
implementation, as these interfaces are not suppose to be implemented by users.
For the case here, adding a default method for a Builder does not make sense...
It will easily lead developers to miss the setter for a field and cause
problem...
> Address 2.1.0 Compatibility Report Issues
> -----------------------------------------
>
> Key: HBASE-20862
> URL: https://issues.apache.org/jira/browse/HBASE-20862
> Project: HBase
> Issue Type: Task
> Components: compatibility
> Affects Versions: 2.1.0
> Reporter: Mike Drob
> Priority: Major
>
> <To Be Filled In>
> https://dist.apache.org/repos/dist/dev/hbase/2.1.0RC0/compatibility_report_2.0.0vs2.1.0RC0.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
