[ 
https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541128#comment-16541128
 ] 

Toshihiro Suzuki commented on HBASE-19572:
------------------------------------------

Thank you for reviewing [~reidchan].

Regarding 1, If I remember correctly, I thought we needed to make "final int 
port" package private for test, so I made all members package private for 
consistency. But I don't think it's strong reason, I'll revert it.

Regarding 2, I think "final Configuration conf" is not a member of RegionMover, 
but RegionMoverBuilder. What did you mean?

Thanks.

> RegionMover should use the configured default port number and not the one 
> from HConstants
> -----------------------------------------------------------------------------------------
>
>                 Key: HBASE-19572
>                 URL: https://issues.apache.org/jira/browse/HBASE-19572
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Esteban Gutierrez
>            Assignee: Toshihiro Suzuki
>            Priority: Major
>         Attachments: HBASE-19572.master.001.patch, 
> HBASE-19572.master.001.patch, HBASE-19572.master.003.patch, 
> HBASE-19572.master.004.patch, HBASE-19572.master.004.patch, 
> HBASE-19572.patch, HBASE-19572.patch
>
>
> The issue I ran into HBASE-19499 was due RegionMover not using the port used 
> by {{hbase-site.xml}}. The tool should use the value used in the 
> configuration before falling back to the hardcoded value 
> {{HConstants.DEFAULT_REGIONSERVER_PORT}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to