[
https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541150#comment-16541150
]
Reid Chan commented on HBASE-19572:
-----------------------------------
Oh ye, it's {{RegionMoverBuilder}}.
{code}
+ private static Configuration createConf() {
+ Configuration conf = HBaseConfiguration.create();
+ conf.setInt("hbase.client.prefetch.limit", 1);
+ conf.setInt("hbase.client.pause", 500);
+ conf.setInt("hbase.client.retries.number", 100);
+ return conf;
+ }
{code}
I think there's a conf in super class {{AbstractHBaseTool.conf}}, should we
create a new one unless is null? Following should be fine, (origin one also has
problem).
{code}
+ private static Configuration createConf() {
+ if (conf == null) {
+ conf = HBaseConfiguration.create();
+ }
+ conf.setInt("hbase.client.prefetch.limit", 1);
+ conf.setInt("hbase.client.pause", 500);
+ conf.setInt("hbase.client.retries.number", 100);
+ return conf;
+ }
{code}
bq. What did you mean?
{code}
+ } else {
+ this.port = conf.getInt(HConstants.REGIONSERVER_PORT,
HConstants.DEFAULT_REGIONSERVER_PORT);
}
setDefaultfilename(this.hostname);
+ this.conf = conf;
{code}
I only see it used for initializing port and does nothing afterwards, so i
doubt it to be a member of {{RegionMoverBuilder}}.
> RegionMover should use the configured default port number and not the one
> from HConstants
> -----------------------------------------------------------------------------------------
>
> Key: HBASE-19572
> URL: https://issues.apache.org/jira/browse/HBASE-19572
> Project: HBase
> Issue Type: Bug
> Reporter: Esteban Gutierrez
> Assignee: Toshihiro Suzuki
> Priority: Major
> Attachments: HBASE-19572.master.001.patch,
> HBASE-19572.master.001.patch, HBASE-19572.master.003.patch,
> HBASE-19572.master.004.patch, HBASE-19572.master.004.patch,
> HBASE-19572.patch, HBASE-19572.patch
>
>
> The issue I ran into HBASE-19499 was due RegionMover not using the port used
> by {{hbase-site.xml}}. The tool should use the value used in the
> configuration before falling back to the hardcoded value
> {{HConstants.DEFAULT_REGIONSERVER_PORT}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
