[jira] [Commented] (HBASE-19572) RegionMover should use the configured default port number and not the one from HConstants

[Toshihiro Suzuki (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HBASE-19572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541207#comment-16541207
 ] 

Toshihiro Suzuki commented on HBASE-19572:
------------------------------------------

[~reidchan] I think we need the "conf" as a member of RegionMoverBuilder, 
because its instance is created in RegionMoverBuilder and then it's passed to 
RegionMover:
{code}
  private RegionMover(RegionMoverBuilder builder) {
    this.hostname = builder.hostname;
    this.filename = builder.filename;
    this.excludeFile = builder.excludeFile;
    this.maxthreads = builder.maxthreads;
    this.ack = builder.ack;
    this.port = builder.port;
    this.timeout = builder.timeout;
    setConf(builder.conf); // here
  }
{code}

If you agree, I'll upload a new patch. Thanks. 

> RegionMover should use the configured default port number and not the one 
> from HConstants
> -----------------------------------------------------------------------------------------
>
>                 Key: HBASE-19572
>                 URL: https://issues.apache.org/jira/browse/HBASE-19572
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Esteban Gutierrez
>            Assignee: Toshihiro Suzuki
>            Priority: Major
>         Attachments: HBASE-19572.master.001.patch, 
> HBASE-19572.master.001.patch, HBASE-19572.master.003.patch, 
> HBASE-19572.master.004.patch, HBASE-19572.master.004.patch, 
> HBASE-19572.patch, HBASE-19572.patch
>
>
> The issue I ran into HBASE-19499 was due RegionMover not using the port used 
> by {{hbase-site.xml}}. The tool should use the value used in the 
> configuration before falling back to the hardcoded value 
> {{HConstants.DEFAULT_REGIONSERVER_PORT}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)