[ 
https://issues.apache.org/jira/browse/HBASE-21088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16587960#comment-16587960
 ] 

stack commented on HBASE-21088:
-------------------------------

Where did this issue come from? A bug found in a deploy? A debug session? Or is 
it just random code reading? Without it, there is no sense of import, or damage 
done, or rate of incidence?

On this issue, why not a finally block? The IOE could come out and the files 
will be still open, no?

> HStoreFile should be closed in HStore#hasReferences
> ---------------------------------------------------
>
>                 Key: HBASE-21088
>                 URL: https://issues.apache.org/jira/browse/HBASE-21088
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Major
>         Attachments: 21088.v1.txt
>
>
> {code}
>       reloadedStoreFiles = loadStoreFiles();
>       return StoreUtils.hasReferences(reloadedStoreFiles);
> {code}
> The intention of obtaining the HStoreFile's is to check for references.
> The loaded HStoreFile's should be closed prior to return to prevent leak.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to