[
https://issues.apache.org/jira/browse/HBASE-21088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589008#comment-16589008
]
stack commented on HBASE-21088:
-------------------------------
Yeah. Seems totally cryptic to me.
Suggest something like this where the close is connected to the location at
which the files are opened:
{code}
try {
reloadedStoreFiles = loadStoreFiles();
return StoreUtils.hasReferences(reloadedStoreFiles);
} finally {
..... do close
}
{code}
> HStoreFile should be closed in HStore#hasReferences
> ---------------------------------------------------
>
> Key: HBASE-21088
> URL: https://issues.apache.org/jira/browse/HBASE-21088
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Major
> Attachments: 21088.v1.txt, 21088.v2.txt, 21088.v2.txt
>
>
> {code}
> reloadedStoreFiles = loadStoreFiles();
> return StoreUtils.hasReferences(reloadedStoreFiles);
> {code}
> The intention of obtaining the HStoreFile's is to check for references.
> The loaded HStoreFile's should be closed prior to return to prevent leak.
> I noticed the increase in open files when running test suite. After checking
> recently modified code, I came to this particular method.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
