[
https://issues.apache.org/jira/browse/HBASE-21088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588004#comment-16588004
]
stack commented on HBASE-21088:
-------------------------------
bq. I noticed the increase in open files when running test suite.
Next time, this would be a good lead-off when creating an issue... Its a fine
objective... How you arrived at the bug and what you are trying to address. The
curt description at the head of this issue says nothing. It makes you look like
you are erratic in where you apply your attention.
Your reasoning on whether or not to close on IOE is probably good but doesn't
it strike you that what is going on here is hard-to-figure and cryptic, likely
to break if mods made in subroutines? Adding the finally even if it might end
up in double-close seems like safe route to me.
> HStoreFile should be closed in HStore#hasReferences
> ---------------------------------------------------
>
> Key: HBASE-21088
> URL: https://issues.apache.org/jira/browse/HBASE-21088
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Major
> Attachments: 21088.v1.txt
>
>
> {code}
> reloadedStoreFiles = loadStoreFiles();
> return StoreUtils.hasReferences(reloadedStoreFiles);
> {code}
> The intention of obtaining the HStoreFile's is to check for references.
> The loaded HStoreFile's should be closed prior to return to prevent leak.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
