[
https://issues.apache.org/jira/browse/HBASE-21553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713144#comment-16713144
]
Andrew Purtell commented on HBASE-21553:
----------------------------------------
The changes look plausible to me. Committer can fix that checkstyle nit on
commit. There is an extra semicolon on one line.
Do you intend to only make this fix on branch-1 [~xucang]? Does it apply to
other branches? If so could do it now or file another issue for forward port.
Awaiting your reply before proceeding.
> schedLock not released in MasterProcedureScheduler
> --------------------------------------------------
>
> Key: HBASE-21553
> URL: https://issues.apache.org/jira/browse/HBASE-21553
> Project: HBase
> Issue Type: Improvement
> Reporter: Xu Cang
> Assignee: Xu Cang
> Priority: Major
> Attachments: HBASE-21553-branch-1.001.patch
>
>
> https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/MasterProcedureScheduler.java#L749
> As shown above, we didn't unlock schedLock which can cause deadlock.
> Besides this, there are other places in this class handles schedLock.unlock
> in a risky manner. I'd like to move them to finally block to improve the
> robustness of handling locks.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
