[
https://issues.apache.org/jira/browse/HBASE-21553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16716035#comment-16716035
]
Sean Busbey commented on HBASE-21553:
-------------------------------------
it looks like the addition of a shared lock check for the namespace came in
HBASE-15105, which means branch-1.2 doesn't have the missed lock release.
Clean up to use try/finally for unlocks is probably still a good idea, but
probably better done as a different JIRA so that folks don't think there's the
same risk of deadlock getting fixed.
> schedLock not released in MasterProcedureScheduler
> --------------------------------------------------
>
> Key: HBASE-21553
> URL: https://issues.apache.org/jira/browse/HBASE-21553
> Project: HBase
> Issue Type: Bug
> Components: proc-v2
> Reporter: Xu Cang
> Assignee: Xu Cang
> Priority: Critical
> Fix For: 1.5.0, 1.3.3, 1.4.10
>
> Attachments: HBASE-21553-branch-1.001.patch,
> HBASE-21553-branch-1.002.patch
>
>
> https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/MasterProcedureScheduler.java#L749
> As shown above, we didn't unlock schedLock which can cause deadlock.
> Besides this, there are other places in this class handles schedLock.unlock
> in a risky manner. I'd like to move them to finally block to improve the
> robustness of handling locks.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
