[ 
https://issues.apache.org/jira/browse/HBASE-21553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16716805#comment-16716805
 ] 

Hudson commented on HBASE-21553:
--------------------------------

Results for branch branch-1.4
        [build #583 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/583/]: 
(x) *{color:red}-1 overall{color}*
----
details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/583//General_Nightly_Build_Report/]


(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/583//JDK7_Nightly_Build_Report/]


(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/583//JDK8_Nightly_Build_Report_(Hadoop2)/]




(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> schedLock not released in MasterProcedureScheduler
> --------------------------------------------------
>
>                 Key: HBASE-21553
>                 URL: https://issues.apache.org/jira/browse/HBASE-21553
>             Project: HBase
>          Issue Type: Bug
>          Components: proc-v2
>            Reporter: Xu Cang
>            Assignee: Xu Cang
>            Priority: Critical
>             Fix For: 1.5.0, 1.3.3, 1.4.10
>
>         Attachments: HBASE-21553-branch-1.001.patch, 
> HBASE-21553-branch-1.002.patch
>
>
> https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/MasterProcedureScheduler.java#L749
> As shown above, we didn't unlock schedLock which can cause deadlock.
> Besides this, there are other places in this class handles schedLock.unlock 
> in a risky manner. I'd like to move them to finally block to improve the 
> robustness of handling locks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to