[ 
https://issues.apache.org/jira/browse/HBASE-22658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16878534#comment-16878534
 ] 

Reid Chan commented on HBASE-22658:
-----------------------------------

bq. Should I checkout source code to branch-1 then change the code as my 
implement
Yes.

You can either generate a patch and attach it here or create a pull request on 
Github. 
bq. Or Should I rename patch file
Yes, if you choose the former. Please refer to [Submit 
patch|http://hbase.apache.org/book.html#submitting.patches] for more details.

> region_mover.rb  should choose same rsgroup servers as target servers 
> ----------------------------------------------------------------------
>
>                 Key: HBASE-22658
>                 URL: https://issues.apache.org/jira/browse/HBASE-22658
>             Project: HBase
>          Issue Type: Improvement
>          Components: rsgroup, shell
>            Reporter: liang.feng
>            Priority: Critical
>              Labels: gracefulshutdown, region_mover, rsgroup
>         Attachments: HBASE-22658-for-hbase1.x-branch-1.4.patch
>
>
> There are many retries when i am using graceful_stop.sh to shutdown region 
> server after using regroup, because the target server in a different rsgroup. 
> This makes it slow to graceful shutdown a regionserver. So i think that 
> region_mover.rb  should only choose same rsgroup servers as target servers.
> Region mover is implemented by jruby in hbase1.x and is  implemented by java 
> in hbase2.x . I tried to modify the RegionMover.java class to use the same 
> logic in hbase2.x, but mvn package failed due to hbase-server module and 
> hbase-rsgroup moudle eeded to depend on each other, then maven throw a "The 
> projects in the reactor contain a cyclic reference". I couldn't solve it.So I 
> just uploaded patch for hbase1.x .
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to