[
https://issues.apache.org/jira/browse/HBASE-22658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16879713#comment-16879713
]
stack commented on HBASE-22658:
-------------------------------
nit: s/isEnableRSGroup/isRSGroup/
Can this be put inside a try/finally... the ruby equivalent...
{code}
334 conn = ConnectionFactory.createConnection(config)
335 rsgroupAdmin = RSGroupAdminClient.new(conn)
336 servers = getSameRSGroupServers(admin, rsgroupAdmin, hostname, port)
337 conn.close()
{code}
Otherwise patch looks good. Does it work?
> region_mover.rb should choose same rsgroup servers as target servers
> ----------------------------------------------------------------------
>
> Key: HBASE-22658
> URL: https://issues.apache.org/jira/browse/HBASE-22658
> Project: HBase
> Issue Type: Improvement
> Components: rsgroup, shell
> Affects Versions: 1.4.10
> Reporter: liang.feng
> Priority: Major
> Labels: gracefulshutdown, region_mover, rsgroup
> Attachments: HBASE-22658.branch-1.patch
>
>
> There are many retries when i am using graceful_stop.sh to shutdown region
> server after using regroup, because the target server in a different rsgroup.
> This makes it slow to graceful shutdown a regionserver. So i think that
> region_mover.rb should only choose same rsgroup servers as target servers.
> Region mover is implemented by jruby in hbase1.x and is implemented by java
> in hbase2.x . I tried to modify the RegionMover.java class to use the same
> logic in hbase2.x, but mvn package failed due to hbase-server module and
> hbase-rsgroup moudle needed to depend on each other, then maven throw a "The
> projects in the reactor contain a cyclic reference". I couldn't solve it.So I
> just uploaded patch for hbase1.x .
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
