[
https://issues.apache.org/jira/browse/HBASE-22658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16880969#comment-16880969
]
liang.feng commented on HBASE-22658:
------------------------------------
1. This method name " isEnableRSGroup" is similar to "is_enabled" command of
the hbase shell.
2. It is really better better to put code inside a try/finally. I will
consider improving it.
3. It works very well in my hbase cluster. My cluster version is hbase 1.4.9.
This patch is based on branch-1, and I've created a pull request at github. The
URL is [https://github.com/apache/hbase/pull/367] .
PS:
You need to change scope of class RSGroupAdminClient to public, if its scope is
private in your code in hbase-rsgroup-xxx.jar
> region_mover.rb should choose same rsgroup servers as target servers
> ----------------------------------------------------------------------
>
> Key: HBASE-22658
> URL: https://issues.apache.org/jira/browse/HBASE-22658
> Project: HBase
> Issue Type: Improvement
> Components: rsgroup, shell
> Affects Versions: 1.4.10
> Reporter: liang.feng
> Priority: Major
> Labels: gracefulshutdown, region_mover, rsgroup
> Attachments: HBASE-22658.branch-1.patch
>
>
> There are many retries when i am using graceful_stop.sh to shutdown region
> server after using regroup, because the target server in a different rsgroup.
> This makes it slow to graceful shutdown a regionserver. So i think that
> region_mover.rb should only choose same rsgroup servers as target servers.
> Region mover is implemented by jruby in hbase1.x and is implemented by java
> in hbase2.x . I tried to modify the RegionMover.java class to use the same
> logic in hbase2.x, but mvn package failed due to hbase-server module and
> hbase-rsgroup moudle needed to depend on each other, then maven throw a "The
> projects in the reactor contain a cyclic reference". I couldn't solve it.So I
> just uploaded patch for hbase1.x .
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
