virajjasani commented on a change in pull request #371: HBASE-22648 :
Introducing Snapshot TTL
URL: https://github.com/apache/hbase/pull/371#discussion_r303164891
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
##########
@@ -1445,6 +1445,9 @@
"hbase.util.default.lossycounting.errorrate";
public static final String NOT_IMPLEMENTED = "Not implemented";
+ // Default Snapshot TTL - 30 days (good enough?)
+ public static final long DEFAULT_SNAPSHOT_TTL = 24 * 3600 * 30;
Review comment:
If the user doesn't specify TTL, we can take above value as TTL by default.
Otherwise we can take user provided TTL anyways. However, if the user decides
to keep the snapshot forever(worst case), the user can specify negative value
as TTL. e.g.:
https://github.com/apache/hbase/pull/371/files#diff-f7c3e813539ba771a69ad518ef8dee00R2772
Does this look good to you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
