virajjasani commented on a change in pull request #371: HBASE-22648 :
Introducing Snapshot TTL
URL: https://github.com/apache/hbase/pull/371#discussion_r303285898
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotDescriptionUtils.java
##########
@@ -124,6 +124,9 @@ public CompletedSnaphotDirectoriesFilter(FileSystem fs) {
/** Default value if no start time is specified */
public static final long NO_SNAPSHOT_START_TIME_SPECIFIED = 0;
+ // Default value if no ttl is specified for Snapshot
+ private static final long NO_SNAPSHOT_TTL_SPECIFIED = 0;
+
public static final String MASTER_SNAPSHOT_TIMEOUT_MILLIS =
"hbase.snapshot.master.timeout.millis";
Review comment:
shell doesn't convert it to ms. this will continue to flow as sec only
untill this point:
https://github.com/apache/hbase/pull/371/files#diff-5fc046382ccaa45c26b89ba3462e8175R92
Please let me know if this looks good to you
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
