virajjasani commented on a change in pull request #371: HBASE-22648 :
Introducing Snapshot TTL
URL: https://github.com/apache/hbase/pull/371#discussion_r303285785
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
##########
@@ -1445,6 +1445,9 @@
"hbase.util.default.lossycounting.errorrate";
public static final String NOT_IMPLEMENTED = "Not implemented";
+ // Default Snapshot TTL - 30 days (good enough?)
+ public static final long DEFAULT_SNAPSHOT_TTL = 24 * 3600 * 30;
Review comment:
@Reidddddd Thanks for your review. Should we keep all previous snapshots
forever? I thought may be 30 days could be good? IMO if the snapshot is kept
for more than a month, it could be a real miss. What is your opinion?
Moreover, I tried to provide one config
**hbase.master.cleaner.snapshot.disable**, which if provided value "true", will
prevent any snapshot from getting deleted - especially useful if some backup
restore activity is going on for a couple of days.
cc: @apurtell
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
