[
https://issues.apache.org/jira/browse/HBASE-22658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16886168#comment-16886168
]
HBase QA commented on HBASE-22658:
----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
36s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m
5s{color} | {color:red} The patch generated 27 new + 353 unchanged - 3 fixed =
380 total (was 356) {color} |
| {color:green}+1{color} | {color:green} ruby-lint {color} | {color:green} 0m
2s{color} | {color:green} There were no new ruby-lint issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
16s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 1m 22s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=18.09.7 Server=18.09.7 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/634/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22658 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12974829/HBASE-22658.branch-1.002.patch
|
| Optional Tests | dupname asflicense rubocop ruby_lint |
| uname | Linux 9bf8b2f59757 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-1 / 1340706 |
| maven | version: Apache Maven 3.0.5 |
| rubocop | v0.72.0 |
| rubocop |
https://builds.apache.org/job/PreCommit-HBASE-Build/634/artifact/patchprocess/diff-patch-rubocop.txt
|
| ruby-lint | v2.3.1 |
| Max. process+thread count | 36 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/634/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
> region_mover.rb should choose same rsgroup servers as target servers
> ----------------------------------------------------------------------
>
> Key: HBASE-22658
> URL: https://issues.apache.org/jira/browse/HBASE-22658
> Project: HBase
> Issue Type: Improvement
> Components: rsgroup, shell
> Affects Versions: 1.4.10
> Reporter: liang.feng
> Priority: Major
> Labels: gracefulshutdown, region_mover, rsgroup
> Attachments: HBASE-22658.branch-1.002.patch,
> HBASE-22658.branch-1.patch
>
>
> There are many retries when i am using graceful_stop.sh to shutdown region
> server after using regroup, because the target server in a different rsgroup.
> This makes it slow to graceful shutdown a regionserver. So i think that
> region_mover.rb should only choose same rsgroup servers as target servers.
> Region mover is implemented by jruby in hbase1.x and is implemented by java
> in hbase2.x . I tried to modify the RegionMover.java class to use the same
> logic in hbase2.x, but mvn package failed due to hbase-server module and
> hbase-rsgroup moudle needed to depend on each other, then maven throw a "The
> projects in the reactor contain a cyclic reference". I couldn't solve it.So I
> just uploaded patch for hbase1.x .
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
