Apache9 commented on a change in pull request #426: HBASE-22695 Store the 
rsgroup of a table in table configuration
URL: https://github.com/apache/hbase/pull/426#discussion_r308595037
 
 

 ##########
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminClient.java
 ##########
 @@ -76,7 +82,6 @@ public RSGroupInfo getRSGroupInfo(String groupName) throws 
IOException {
     }
   }
 
-  @Override
   public RSGroupInfo getRSGroupInfoOfTable(TableName tableName) throws 
IOException {
 
 Review comment:
   I think we will reference this method in hbase shell so do not want to 
change it in this patch...
   
   Let's do it in another issue. And in general, if we do not want to 
completely remove the shell command, we'd better keep this method for a least a 
whole major version?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to