Apache9 commented on a change in pull request #426: HBASE-22695 Store the
rsgroup of a table in table configuration
URL: https://github.com/apache/hbase/pull/426#discussion_r310129795
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java
##########
@@ -524,100 +398,66 @@ public RSGroupInfo getRSGroupOfServer(Address hostPort)
throws IOException {
}
@Override
- public void moveServersAndTables(Set<Address> servers, Set<TableName>
tables, String targetGroup)
- throws IOException {
+ public void removeServers(Set<Address> servers) throws IOException {
if (servers == null || servers.isEmpty()) {
- throw new ConstraintException("The list of servers to move cannot be
null or empty.");
- }
- if (tables == null || tables.isEmpty()) {
- throw new ConstraintException("The list of tables to move cannot be null
or empty.");
+ throw new ConstraintException("The set of servers to remove cannot be
null or empty.");
}
-
- //check target group
- getAndCheckRSGroupInfo(targetGroup);
-
- // Hold a lock on the manager instance while moving servers and tables to
prevent
+ // Hold a lock on the manager instance while moving servers to prevent
// another writer changing our state while we are working.
synchronized (rsGroupInfoManager) {
- //check servers and tables status
- checkServersAndTables(servers, tables, targetGroup);
-
- //Move servers and tables to a new group.
- String srcGroup =
getRSGroupOfServer(servers.iterator().next()).getName();
- rsGroupInfoManager.moveServersAndTables(servers, tables, srcGroup,
targetGroup);
-
- //move regions on these servers which do not belong to group tables
- moveServerRegionsFromGroup(servers, targetGroup);
- //move regions of these tables which are not on group servers
- moveTableRegionsToGroup(tables, targetGroup);
+ // check the set of servers
+ checkForDeadOrOnlineServers(servers);
+ rsGroupInfoManager.removeServers(servers);
+ LOG.info("Remove decommissioned servers {} from RSGroup done", servers);
Review comment:
I haven't changed the logic here, just formatting. I guess the removeServers
method is to completely remove servers from any rs groups, that;s why they use
the word 'decommissioned'.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
