Apache9 commented on a change in pull request #426: HBASE-22695 Store the rsgroup of a table in table configuration URL: https://github.com/apache/hbase/pull/426#discussion_r309998255
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupUtil.java ########## @@ -0,0 +1,113 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable + * law or agreed to in writing, software distributed under the License is distributed on an "AS IS" + * BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License + * for the specific language governing permissions and limitations under the License. + */ +package org.apache.hadoop.hbase.rsgroup; + +import java.io.IOException; +import java.util.Collection; +import java.util.Optional; +import java.util.function.Predicate; +import org.apache.hadoop.hbase.NamespaceDescriptor; +import org.apache.hadoop.hbase.TableName; +import org.apache.hadoop.hbase.client.TableDescriptor; +import org.apache.hadoop.hbase.master.ClusterSchema; +import org.apache.hadoop.hbase.master.MasterServices; +import org.apache.yetus.audience.InterfaceAudience; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Helper class for RSGroup implementation + */ [email protected] +final class RSGroupUtil { + + private static final Logger LOG = LoggerFactory.getLogger(RSGroupUtil.class); + + private RSGroupUtil() { + } + + @FunctionalInterface + private interface GetRSGroup { + RSGroupInfo get(String groupName) throws IOException; + } + + private static Optional<RSGroupInfo> getRSGroupInfo(MasterServices master, GetRSGroup getter, + TableName tableName) throws IOException { + TableDescriptor td = master.getTableDescriptors().get(tableName); + if (td == null) { + return Optional.empty(); + } + Optional<String> optGroupNameOfTable = td.getRegionServerGroup(); + if (optGroupNameOfTable.isPresent()) { + RSGroupInfo group = getter.get(optGroupNameOfTable.get()); + if (group != null) { + return Optional.of(group); + } + } + ClusterSchema clusterSchema = master.getClusterSchema(); + if (clusterSchema == null) { + if (TableName.isMetaTableName(tableName)) { + LOG.info("Can not get the namespace rs group config for meta table, since the" + + " meta table is not online yet, will use default group to assign meta first"); + } else { + LOG.warn("ClusterSchema is null, can only use default rsgroup, should not happen?"); + } + return Optional.empty(); + } + NamespaceDescriptor nd = clusterSchema.getNamespace(tableName.getNamespaceAsString()); + String groupNameOfNs = nd.getConfigurationValue(RSGroupInfo.NAMESPACE_DESC_PROP_GROUP); + if (groupNameOfNs == null) { + return Optional.empty(); Review comment: Empty here can tell the upper layer that there is no rs group setting for this table. If we return default rs group here, the upper layer can not know if there is no rs group setting, or user set the rs group to default explicitly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
