openinx commented on a change in pull request #437: HBASE-22539 WAL corruption
due to early DBBs re-use when Durability.A…
URL: https://github.com/apache/hbase/pull/437#discussion_r309959424
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AsyncFSWAL.java
##########
@@ -487,6 +490,7 @@ private void drainNonMarkerEditsAndFailSyncs() {
while (iter.hasNext()) {
FSWALEntry entry = iter.next();
if (!entry.getEdit().isMetaEdit()) {
+ entry.getRpcCall().ifPresent(ServerCall::releaseByWAL);
Review comment:
In theory, once we remove a FSWALEntry from the unackedAppended deque, we
should release the BB backend the WAL ? Could we define a deque subclass, once
we remove the entry from it then will release it , then we don't need to
release the wal everywhere, I think...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
