openinx commented on a change in pull request #437: HBASE-22539 WAL corruption
due to early DBBs re-use when Durability.A…
URL: https://github.com/apache/hbase/pull/437#discussion_r309956708
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
##########
@@ -1002,6 +1001,8 @@ public void onEvent(final RingBufferTruck truck, final
long sequence, boolean en
: new DamagedWALException("On sync", this.exception));
// Return to keep processing events coming off the ringbuffer
return;
+ } finally {
+ entry.getRpcCall().ifPresent(ServerCall::releaseByWAL);
Review comment:
Good. Releasing the BB here should be fine, because once the BB was written
into the outputStream, it would be copied to a new memory area, won't depend on
the rpc BB now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
