[
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907675#comment-16907675
]
Xu Cang commented on HBASE-22804:
---------------------------------
I have several nits:
1.
{code:java}
import static org.junit.Assert.*;{code}
Usually we do not use * in import.
2. please remove the extra empty line after
{code:java}
for (String regionName : regionMap.keySet()) {{code}
Otherwise all look good to me! thanks!
I'd suggest get the subtask committed before committing this one.
> Provide an API to get list of successful regions and total expected regions
> in Canary
> -------------------------------------------------------------------------------------
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
> Issue Type: Improvement
> Components: canary
> Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
> Reporter: Caroline
> Assignee: Caroline
> Priority: Minor
> Labels: Canary
> Attachments: HBASE-22804.branch-1.001.patch,
> HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch,
> HBASE-22804.branch-1.004.patch, HBASE-22804.branch-2.001.patch,
> HBASE-22804.branch-2.002.patch, HBASE-22804.branch-2.003.patch,
> HBASE-22804.branch-2.004.patch, HBASE-22804.master.001.patch,
> HBASE-22804.master.002.patch, HBASE-22804.master.003.patch,
> HBASE-22804.master.004.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs.
> Providing an API to get the list of successes, as well as total number of
> expected regions, will make it easier to get a more accurate availability
> estimate.
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
