[ 
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16903497#comment-16903497
 ] 

stack commented on HBASE-22804:
-------------------------------

Looks good to me.


51      import com.google.common.collect.Maps;

... see how avoid direct reference to guava and instead use a shaded internal 
version at org.apache.hbase.thirdparty.....  That is probably what the above 
shadedjars complaints are about.

Should this be an Interface so we can add more methods to it w/o breaking it 
(using 'default' implementations?) given it looks like you have to embed the 
Canary to get access to these new APIs?

> Provide an API to get list of successful regions and total expected regions 
> in Canary
> -------------------------------------------------------------------------------------
>
>                 Key: HBASE-22804
>                 URL: https://issues.apache.org/jira/browse/HBASE-22804
>             Project: HBase
>          Issue Type: Improvement
>          Components: canary
>    Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
>            Reporter: Caroline
>            Assignee: Caroline
>            Priority: Minor
>              Labels: Canary
>         Attachments: HBASE-22804.branch-1.001.patch, 
> HBASE-22804.branch-2.001.patch, HBASE-22804.master.001.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs. 
> Providing an API to get the list of successes, as well as total number of 
> expected regions, will make it easier to get a more accurate availability 
> estimate.
>   



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to