[
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16903292#comment-16903292
]
Andrew Purtell commented on HBASE-22804:
----------------------------------------
Patches basically lgtm
Canary is marked as a Private class. This means these interfaces could change
at any time. Should we change the annotation on Canary to Public/Evolving? Or
add annotations on some of these subtypes?
I think it depends on how we think Canary results should be consumed.
In our production we find that scraping logs and parsing them is brittle and
not scalable. Although the scalability issue is more to do with the totality of
logs from a Hadoopish stack, if you run HBase then you have this problem, and
you wouldn't be using the canary if you didn't run HBase. We have a tool that
embeds the Canary and calls various methods.
Therefore I propose that there be a follow up patch which makes Canary
Public/Evolving.
With that in mind, the API changes are fine.
> Provide an API to get list of successful regions and total expected regions
> in Canary
> -------------------------------------------------------------------------------------
>
> Key: HBASE-22804
> URL: https://issues.apache.org/jira/browse/HBASE-22804
> Project: HBase
> Issue Type: Improvement
> Components: canary
> Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
> Reporter: Caroline
> Assignee: Caroline
> Priority: Minor
> Labels: Canary
> Attachments: HBASE-22804.branch-1.000.patch,
> HBASE-22804.branch-2.000.patch, HBASE-22804.master.000.patch
>
>
> At present HBase Canary tool only prints the successes as part of logs.
> Providing an API to get the list of successes, as well as total number of
> expected regions, will make it easier to get a more accurate availability
> estimate.
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
