Reidddddd commented on a change in pull request #527: HBASE-22880 Move the
DirScanPool out and do not use static field
URL: https://github.com/apache/hbase/pull/527#discussion_r316963014
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -1237,22 +1239,18 @@ private void startServiceThreads() throws IOException {
this.service.startExecutorService(ExecutorType.MASTER_TABLE_OPERATIONS, 1);
startProcedureExecutor();
- // Initial cleaner chore
- CleanerChore.initChorePool(conf);
- // Start log cleaner thread
- int cleanerInterval = conf.getInt("hbase.master.cleaner.interval", 60 *
1000);
- this.logCleaner =
- new LogCleaner(cleanerInterval,
- this, conf, getMasterFileSystem().getOldLogDir().getFileSystem(conf),
- getMasterFileSystem().getOldLogDir());
- getChoreService().scheduleChore(logCleaner);
-
+ // Create cleaner thread pool
+ cleanerPool = new DirScanPool(conf);
+ // Start log cleaner thread
+ int cleanerInterval = conf.getInt("hbase.master.cleaner.interval", 600 *
1000);
+ this.logCleaner = new LogCleaner(cleanerInterval, this, conf,
+ getMasterFileSystem().getOldLogDir().getFileSystem(conf),
getMasterFileSystem().getOldLogDir(), cleanerPool);
Review comment:
nit: two indents
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
