Reidddddd commented on a change in pull request #527: HBASE-22880 Move the
DirScanPool out and do not use static field
URL: https://github.com/apache/hbase/pull/527#discussion_r316963285
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
##########
@@ -156,22 +73,9 @@ synchronized void shutDownNow() {
protected Map<String, Object> params;
private AtomicBoolean enabled = new AtomicBoolean(true);
- public static void initChorePool(Configuration conf) {
- if (POOL == null) {
- POOL = new DirScanPool(conf);
- }
- }
-
- public static void shutDownChorePool() {
- if (POOL != null) {
- POOL.shutDownNow();
- POOL = null;
- }
- }
-
public CleanerChore(String name, final int sleepPeriod, final Stoppable s,
Configuration conf,
- FileSystem fs, Path oldFileDir, String confKey) {
- this(name, sleepPeriod, s, conf, fs, oldFileDir, confKey, null);
+ FileSystem fs, Path oldFileDir, String confKey,
DirScanPool pool) {
+ this(name, sleepPeriod, s, conf, fs, oldFileDir, confKey,pool, null);
Review comment:
nit, space between `,pool`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
