Reidddddd commented on a change in pull request #527: HBASE-22880 Move the
DirScanPool out and do not use static field
URL: https://github.com/apache/hbase/pull/527#discussion_r317013230
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestHFileLinkCleaner.java
##########
@@ -36,23 +36,39 @@
import org.apache.hadoop.hbase.TableName;
import org.apache.hadoop.hbase.client.ClusterConnection;
import org.apache.hadoop.hbase.io.HFileLink;
+import org.apache.hadoop.hbase.testclassification.MasterTests;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
import org.apache.hadoop.hbase.testclassification.SmallTests;
import org.apache.hadoop.hbase.util.FSUtils;
import org.apache.hadoop.hbase.util.HFileArchiveUtil;
import org.apache.hadoop.hbase.zookeeper.MetaTableLocator;
import org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
import org.junit.Test;
import org.junit.experimental.categories.Category;
/**
- * Test the HFileLink Cleaner.
- * HFiles with links cannot be deleted until a link is present.
+ * Test the HFileLink Cleaner. HFiles with links cannot be deleted until a
link is present.
*/
-@Category(SmallTests.class)
+@Category(MediumTests.class)
public class TestHFileLinkCleaner {
private final static HBaseTestingUtility TEST_UTIL = new
HBaseTestingUtility();
+ private static DirScanPool POOL;
+
+ @BeforeClass
+ public static void setUp() {
+ POOL = new DirScanPool(TEST_UTIL.getConfiguration());
+ }
+
+ @AfterClass
+ public static void tearDown() {
+ POOL.shutdownNow();
+ }
+
Review comment:
nit, just keep one empty line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
