[
https://issues.apache.org/jira/browse/HBASE-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247097#comment-13247097
]
Jonathan Hsieh commented on HBASE-5644:
---------------------------------------
First quick review (I have more to review, will continue hopefully in next day)
Test failure on TestSplitTransactionOnCluster seems to be legit -- it hung on
my machine locally 2x.
Have you used Preconditions before? It is slightly more compact and seems
little better at conveying intent.
http://google-collections.googlecode.com/svn/trunk/javadoc/com/google/common/base/Preconditions.html
There was another NP findbugs warnings from build 1365: Mind handling this one
too?
Possible null pointer dereference of serverInfo in
org.apache.hadoop.hbase.tmpl.regionserver.RSStatusTmplImpl.renderNoFlush(Writer)
on exception path
> [findbugs] Fix null pointer warnings.
> -------------------------------------
>
> Key: HBASE-5644
> URL: https://issues.apache.org/jira/browse/HBASE-5644
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: Uma Maheswara Rao G
> Attachments: HBASE-5644.patch, NullPointerFindBugs_Analysis.xlsx
>
>
> See
> https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the NP category
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
