[
https://issues.apache.org/jira/browse/HBASE-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247253#comment-13247253
]
Uma Maheswara Rao G commented on HBASE-5644:
--------------------------------------------
Thanks a lot Jon for taking a look.
{quote}
Test failure on TestSplitTransactionOnCluster seems to be legit – it hung on my
machine locally 2x.
{quote}
Looks TestSplitTransactionOnCluster is failing randomly with out the patch as
well. Just filed HBASE-5726.
{quote}
Have you used Preconditions before? It is slightly more compact and seems
little better at conveying intent.
{quote}
Used, but not extensively ( only in Hadoop). are you suggesting not to use it
here?
{quote}
There was another NP findbugs warnings from build 1365: Mind handling this one
too?
Possible null pointer dereference of serverInfo in
org.apache.hadoop.hbase.tmpl.regionserver.RSStatusTmplImpl.renderNoFlush(Writer)
on exception path
{quote}
Yes, I added this comment remarks in my analysis sheet.
RSStatusTmplImpl is Autogenerated Jamon code. I wanted to fix it but I am not
familiar in Jamon code generation area :(. Let some one or you can update this
change if you are familiar. If not, can I file a separate bug?
{code}
HServerInfo serverInfo = null;
ServerName serverName = null;
try {
serverInfo = regionServer.getHServerInfo();
serverName = regionServer.getServerName();
} catch (IOException e) {
e.printStackTrace();
}
{code}
It is ignoring the exception here and proceeding and using serverInfo. This can
cause NPE here if getHServerInfo throws IOE.
> [findbugs] Fix null pointer warnings.
> -------------------------------------
>
> Key: HBASE-5644
> URL: https://issues.apache.org/jira/browse/HBASE-5644
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: Uma Maheswara Rao G
> Attachments: HBASE-5644.patch, NullPointerFindBugs_Analysis.xlsx
>
>
> See
> https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the NP category
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
